error in string->char-set

[Michael Becker <mb12@coconet.de>]

scsh-version 0.3 :


there is an error in string->char-set:

(define (string->char-set str)
  (let ((char-set (make-string 256 (ascii->char 0))))
    (let lp ((i (string-length str))) ; too big
      (cond ((zero? i)                ; should be (>= i 0)
             (string-set! char-set (char->ascii (string-ref str i))
                          (ascii->char 1))
             (lp (- i 1)))))
    char-set))

should be changed to :

(define (string->char-set str)
  (let ((char-set (make-string 256 (ascii->char 0))))
    (let lp ((i (- (string-length str) 1)))
      (cond ((>= i 0)
             (string-set! char-set (char->ascii (string-ref str i))
                          (ascii->char 1))
             (lp (- i 1)))))
    char-set))

m.becker