scsh-hackers
[Top] [All Lists]

[Scsh-hackers] [ scsh-Bugs-407805 ] dynload.c and bsd/waitcodes.scm

To: noreply@sourceforge.net
Subject: [Scsh-hackers] [ scsh-Bugs-407805 ] dynload.c and bsd/waitcodes.scm
From: nobody <nobody@sourceforge.net>
Date: Sun, 11 Mar 2001 18:25:46 -0800
List-id: Discussion among the implementors <scsh-hackers.lists.sourceforge.net>
Sender: scsh-hackers-admin@lists.sourceforge.net
Bugs #407805, was updated on 2001-03-11 18:25
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=110493&aid=407805&group_id=10493

Category: run-time
Group: None
Status: Open
Priority: 1
Submitted By: Brian D. Carlstrom
Assigned to: Brian D. Carlstrom
Summary: dynload.c and bsd/waitcodes.scm

Initial Comment:
From: Alan Bawden <Alan@LCS.MIT.EDU>
Sender: Alan@LCS.MIT.EDU
To: scsh-bugs@martigny.ai.mit.edu
Subject: dynload.c and bsd/waitcodes.scm
Date: Wed, 8 Jan 1997 01:38:28 -0500

Two problems to report in scsh 0.4.4:

------- #1

scsh-0.4.4/dynload.c contains the following code:

    newhandle=dlopen(pathname, S48_DLOPEN_MODE);
  #if defined(__NetBSD__) || defined(__FreeBSD__)
    if (newhandle == -1) {
      fprintf(stderr, " dynamic_load of %s can't 
dlopen %s",
              sharedobjname, pathname);
      return -1;
    };
  #else
    if (!newhandle) {
      fprintf(stderr, " dynamic_load of %s can't 
dlopen %s: %s ",
              sharedobjname, pathname, dlerror());
      return -1;
    };
  #endif

First off, the manual page for dlopen() on FreeBSD 
version 2.1.0
claims that dlopen returns a null pointer if it 
fails.  That manual page
also claims that dlerror() is supported.  I do seem to 
recall that previous
versions of FreeBSD had some undocumented dynamic 
loading support, so
perhaps this code is a hold-over from those old days.  
Probably autoconf
should be figuring this out for you somehow...

Second off, this code generates a compile-time warning 
because of the
comparison between newhandle and -1.  Since this is 
the -only- warning I
got when installing scsh, you might want to achieve 
perfection by replacing
that "-1" with "(void *) -1"!

------- #2

In scsh-0.4.4/scsh/bsd/waitcodes.scm the line:

         (not (= 
#x7F))                                 ; Not suspended.

should probably read:
  
         (not (= #x7F 
termsig))                         ; Not suspended.

------- EOM







----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=110493&aid=407805&group_id=10493


<Prev in Thread] Current Thread [Next in Thread>